[webkit-reviews] review denied: [Bug 136141] r171362 accidentally increased the size of InlineCallFrame : [Attachment 236948] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 21 17:57:01 PDT 2014


Mark Lam <mark.lam at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 136141: r171362 accidentally increased the size of InlineCallFrame
https://bugs.webkit.org/show_bug.cgi?id=136141

Attachment 236948: The patch
https://bugs.webkit.org/attachment.cgi?id=236948&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236948&action=review


> Source/JavaScriptCore/bytecode/CodeOrigin.h:164
> +    static const int maxStackOffset = (1 << 29) - 1;
> +    static const int minStackOffset = (~0 << 29);

Wrong limits.


More information about the webkit-reviews mailing list