[webkit-reviews] review granted: [Bug 136133] Add a button to enable paint flashing in the web inspector : [Attachment 236939] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 136133: Add a button to enable paint flashing in the web inspector
https://bugs.webkit.org/show_bug.cgi?id=136133

Attachment 236939: Patch
https://bugs.webkit.org/attachment.cgi?id=236939&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236939&action=review


> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:36
> +	   paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 16,
height: 16};

This isn't needed since the two image paths are the same.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:40
> +	   paintFlashingImage = {src: "Images/PaintFlashing.svg", width: 13,
height: 13};

Ditto.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:47
> +    this._paintFlashingButtonNavigationItem = new
WebInspector.ActivateButtonNavigationItem("paint-flashing",
WebInspector.UIString("Enable paint flashing"), WebInspector.UIString("Disable
paint flashing"), paintFlashingImage.src, paintFlashingImage.width,
paintFlashingImage.height);

You can use put the image path and size directly here. The width and height
should always be 16 to match the SVG.