[webkit-reviews] review granted: [Bug 136082] Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API : [Attachment 236936] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 136082: Replace use of WKCopyCFLocalizationPreferredName with NSLocale
public API
https://bugs.webkit.org/show_bug.cgi?id=136082

Attachment 236936: Patch
https://bugs.webkit.org/attachment.cgi?id=236936&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236936&action=review


> Source/WebCore/platform/mac/WebCoreNSStringExtras.mm:132
> +    if (!preferredLocalizations || ![preferredLocalizations count])

Since it's Objective-C, "[preferredLocalizations count]" would be sufficient to
check for.

> Source/WebCore/platform/mac/WebCoreNSStringExtras.mm:135
> +    return canonicalLocaleName([ objectAtIndex:0]);

This won't build, missing message receive.