[webkit-reviews] review granted: [Bug 136063] REGRESSION: CSS not() selector does not work when it appears after or within @supports : [Attachment 236914] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 136063: REGRESSION: CSS not() selector does not work when it appears after
or within @supports
https://bugs.webkit.org/show_bug.cgi?id=136063

Attachment 236914: Patch
https://bugs.webkit.org/attachment.cgi?id=236914&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236914&action=review


> Source/WebCore/css/CSSParser.cpp:11352
> +	   bool isParsingCondition = m_parsingMode == MediaQueryMode;
> +#if ENABLE(CSS3_CONDITIONAL_RULES)
> +	   isParsingCondition = isParsingCondition || m_parsingMode ==
SupportsMode;
> +#endif
> +	   if (isParsingCondition)
>	       m_parsingMode = NormalMode;
>	   break;

While this is OK, I think two separate if statements would read more simply:

    if (m_parsingMode == MediaQueryMode)
	m_parsingMode = NormalMode;
#if ENABLE(CSS3_CONDITIONAL_RULES)
    if (m_parsingMode == SupportsMode)
	m_parsingMode = NormalMode;
#endif