[webkit-reviews] review requested: [Bug 135945] [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS and ENABLE_XSLT when building with the iOS public SDK : [Attachment 236899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 20 15:17:14 PDT 2014


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 135945: [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily
disable ENABLE_TOUCH_EVENTS and ENABLE_XSLT when building with the iOS public
SDK
https://bugs.webkit.org/show_bug.cgi?id=135945

Attachment 236899: Patch
https://bugs.webkit.org/attachment.cgi?id=236899&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch. I chose to use USE(APPLE_INTERNAL_SDK) instead of checking for
the existence of a specific header file when defining
ENABLE_IOS_GESTURE_EVENTS, ENABLE_IOS_TOUCH_EVENTS, and ENABLE_XSLT in file
Source/WTF/wtf/FeatureDefines.h so as to be materially consistent with the
xcconfig logic in this patch for the same feature defines. Let me know if it's
preferred to check for a header file when defining these feature defines.


More information about the webkit-reviews mailing list