[webkit-reviews] review granted: [Bug 136118] Stop implicitly skipping a function's own activation when walking the scope chain : [Attachment 236894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 20 13:45:54 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 136118: Stop implicitly skipping a function's own activation when walking
the scope chain
https://bugs.webkit.org/show_bug.cgi?id=136118

Attachment 236894: Patch
https://bugs.webkit.org/attachment.cgi?id=236894&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

If the extra pointer dereference is a performance hit, perhaps we need a
DFG/FTL optimization to infer that your parent scopes are constants. It seems
like, at each level up the scope chain, the odds of a constant scope must
increase exponentially.


More information about the webkit-reviews mailing list