[webkit-reviews] review granted: [Bug 136103] [Win] Assertion fails when running JSC stress tests. : [Attachment 236873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 20 09:55:50 PDT 2014


Darin Adler <darin at apple.com> has granted peavo at outlook.com's request for
review:
Bug 136103: [Win] Assertion fails when running JSC stress tests.
https://bugs.webkit.org/show_bug.cgi?id=136103

Attachment 236873: Patch
https://bugs.webkit.org/attachment.cgi?id=236873&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236873&action=review


> Source/JavaScriptCore/bytecode/CodeOrigin.h:143
> +    static CodeSpecializationKind specializationKindFor(unsigned kind)

This change should not be necessary. What happens when you don’t change this?
Some kind of failure to compile?

> Source/JavaScriptCore/bytecode/CodeOrigin.h:163
> +    unsigned kind : 2;

I believe our WebKit coding style pattern in cases like this is to put a
comment off to the right with the name of the enum type. See examples like the
ones in DFGNode.h, RenderObject.h, StyleRareInheritedData.h, and
StyleRareNonInheritedData.h.


More information about the webkit-reviews mailing list