[webkit-reviews] review denied: [Bug 136096] [EFL][WK2] Layout Test storage/websql/sql-error-codes.html is passed : [Attachment 236864] Patch-Updated

[bugzilla-daemon at webkit.org]

Michal Pakula vel Rutka <m.pakula at samsung.com> has denied Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 136096: [EFL][WK2] Layout Test storage/websql/sql-error-codes.html is
passed
https://bugs.webkit.org/show_bug.cgi?id=136096

Attachment 236864: Patch-Updated
https://bugs.webkit.org/attachment.cgi?id=236864&action=review

------- Additional Comments from Michal Pakula vel Rutka <m.pakula at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236864&action=review


I checked on my local machine and the test fails the same as on bot. Anyway we
cannot take results from our local machines as a reference point, instead we
should rely only on build bot results.

> LayoutTests/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

Gardening does not require review, next time please replace this line with
something like: Unreviewed gardening and set only cq? leaving r flag not set.

> LayoutTests/platform/efl/TestExpectations:745
> +webkit.org/b/108355 storage/websql/sql-error-codes.html

Still if test starts to pass you should remove whole entry, not remove the
modifier. Now leaving a test name without modifier means the same as [ Skip ].