[webkit-reviews] review granted: [Bug 136076] Expose injected bundle SPI to get a node's URL element, get the visible selection range of that element, and snapshot that range : [Attachment 236824] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Peyton Randolph
<prandolph at apple.com>'s request for review:
Bug 136076: Expose injected bundle SPI to get a node's URL element, get the
visible selection range of that element, and snapshot that range
https://bugs.webkit.org/show_bug.cgi?id=136076

Attachment 236824: Patch
https://bugs.webkit.org/attachment.cgi?id=236824&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236824&action=review


>
Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:119
> +    float scaleFactor = (options & SnapshotOptionsExcludeDeviceScaleFactor)
? 1 : frame->page()->deviceScaleFactor();

It would be nice if we could share this middle block of code with
InjectedBundleNodeHandle (and WebPage, etc.), but I'm not sure where to put it.