[webkit-reviews] review granted: [Bug 136076] Expose injected bundle SPI to get a node's URL element, get the visible selection range of that element, and snapshot that range : [Attachment 236817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 19 11:54:04 PDT 2014


Tim Horton <thorton at apple.com> has granted Peyton Randolph
<prandolph at apple.com>'s request for review:
Bug 136076: Expose injected bundle SPI to get a node's URL element, get the
visible selection range of that element, and snapshot that range
https://bugs.webkit.org/show_bug.cgi?id=136076

Attachment 236817: Patch
https://bugs.webkit.org/attachment.cgi?id=236817&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236817&action=review


> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:48
> +    PassRefPtr<InjectedBundleNodeHandle> URLElementHandle() const;

https://www.webkit.org/coding/coding-style.html#names-basic says that URL
should be lowercase in all of these instances.


More information about the webkit-reviews mailing list