[webkit-reviews] review denied: [Bug 131461] GenericHashTraits::peek() is producing copies of passed-in temporary values : [Attachment 230513] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Zan Dobersek <zandobersek at gmail.com>'s
request for review:
Bug 131461: GenericHashTraits::peek() is producing copies of passed-in
temporary values
https://bugs.webkit.org/show_bug.cgi?id=131461

Attachment 230513: Patch
https://bugs.webkit.org/attachment.cgi?id=230513&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230513&action=review


I think this patch is fine, but the test doesn’t yet compile on Mac.

> Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:162
> +	   EXPECT_EQ(CopyMoveCounter::constructionCount, 0);
> +	   EXPECT_EQ(CopyMoveCounter::copyCount, 1);
> +	   EXPECT_EQ(CopyMoveCounter::moveCount, 0);

Two problems here. First, the expected value is supposed to come first, and the
thing we are testing is supposed to come second. Second, the type needs to
match, so these need to be 0U and 1U rather than 0 and 1.