[webkit-reviews] review denied: [Bug 136062] New ruby parsing rule breaks some real web sites. : [Attachment 236803] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 136062: New ruby parsing rule breaks some real web sites.
https://bugs.webkit.org/show_bug.cgi?id=136062

Attachment 236803: Patch
https://bugs.webkit.org/attachment.cgi?id=236803&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236803&action=review


Thanks for the patch but we need a new test case demonstrating the issue
reported to Gecko.
r- due to the lack of tests.

> Source/WebCore/ChangeLog:11
> +	   The HTML5 spec was changed at the following commit:
> +	  
https://github.com/w3c/html/commit/c61397b989b28235ee2228f280aa8d475f3b9ebf

It's great to see the hyperlink to the relevant spec change!

> Source/WebCore/ChangeLog:14
> +	   This patch changed the RP element's behavior to follow the spec
change.
> +

We should add a new test.
It would be great if we could use the problem reported at
https://bugzilla.mozilla.org/show_bug.cgi?id=1042885.