[webkit-reviews] review granted: [Bug 136031] Web Inspector: rename Inspector::TypeBuilder to Inspector::Protocol : [Attachment 236741] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 18 23:50:43 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted  review:
Bug 136031: Web Inspector: rename Inspector::TypeBuilder to Inspector::Protocol
https://bugs.webkit.org/show_bug.cgi?id=136031

Attachment 236741: Patch
https://bugs.webkit.org/attachment.cgi?id=236741&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236741&action=review


Rubber-stamp here assuming you can get it applying and building in EWS.

> Source/JavaScriptCore/ChangeLog:9
> +	   Rename TypeBuilder namespace to Protocol. Disambiguate where
> +	   necessary. Also rename InspectorTypeBuilder to ProtocolTypes.

Yay!


More information about the webkit-reviews mailing list