[webkit-reviews] review granted: [Bug 135750] REGRESSION(r172129): ftlopt branch merge made performance tests flakey crash : [Attachment 236779] possible fix

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted  review:
Bug 135750: REGRESSION(r172129): ftlopt branch merge made performance tests
flakey crash
https://bugs.webkit.org/show_bug.cgi?id=135750

Attachment 236779: possible fix
https://bugs.webkit.org/attachment.cgi?id=236779&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236779&action=review


r=me with comment fixes.

> Source/JavaScriptCore/dfg/DFGAbstractValue.cpp:76
>	       // We should be able to assume that the watchpoint for this has
already been set.
>	       // But we can't because our view of what structure a value has
keeps changing. That's
>	       // why we call consider().

Does this comment need to be updated now that we're not calling consider()
here?

> Source/JavaScriptCore/dfg/DFGStructureRegistrationPhase.cpp:47
>	   // These are pretty dumb, but needed to placate subsequent
assertions. We con't actually

/con't/don't/