[webkit-reviews] review granted: [Bug 135896] Move DiskCacheMonitor to WebCore so that WebKit1 clients can use it as well : [Attachment 236774] Patch with more build fixes

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 135896: Move DiskCacheMonitor to WebCore so that WebKit1 clients can use it
as well
https://bugs.webkit.org/show_bug.cgi?id=135896

Attachment 236774: Patch with more build fixes
https://bugs.webkit.org/attachment.cgi?id=236774&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236774&action=review


r=me

> Source/WebCore/ChangeLog:17
> +	       CFNetwork callback block, it calls a virtual function that is
overriden by

Typo, overridden.

> Source/WebKit2/NetworkProcess/mac/NetworkDiskCacheMonitor.h:43
> +class NetworkDiskCacheMonitor : public WebCore::DiskCacheMonitor,
IPC::MessageSender {

This class should be marked "final".