[webkit-reviews] review granted: [Bug 136048] Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture : [Attachment 236782] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Peyton Randolph
<prandolph at apple.com>'s request for review:
Bug 136048: Expose long mouse press WebKit API. Part of 135257 - Add long mouse
press gesture
https://bugs.webkit.org/show_bug.cgi?id=136048

Attachment 236782: Patch
https://bugs.webkit.org/attachment.cgi?id=236782&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review


> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171
> +    WKBundlePageDidBeginTrackingPotentialLongMousePressCallback	     
didBeginTrackingPotentialLongMousePress;
> +    WKBundlePageDidRecognizeLongMousePressCallback			     
didRecognizeLongMousePress;
> +    WKBundlePageDidCancelTrackingPotentialLongMousePressCallback	     
didCancelTrackingPotentialLongMousePress;

These last three aren’t aligned with all of the above.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209
> +    WKTypeRef userDataToPass = 0;

Please use nullptr.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219
> +    WKTypeRef userDataToPass = 0;

Ditto.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229
> +    WKTypeRef userDataToPass = 0;

Ditto.