[webkit-reviews] review granted: [Bug 136016] [EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions to be created without being attached to an AVStreamDataParser. : [Attachment 236776] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 136016: [EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions
to be created without being attached to an AVStreamDataParser.
https://bugs.webkit.org/show_bug.cgi?id=136016

Attachment 236776: Patch
https://bugs.webkit.org/attachment.cgi?id=236776&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236776&action=review


>
Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:6
1
> +	   return
MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters);

Nit: MediaPlayerPrivateMediaSourceAVFObjC::supportsType returns
MediaPlayer::SupportsType, not bool.

>
Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:7
3
> +    return MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters);

Ditto.