[webkit-reviews] review granted: [Bug 133574] ASSERTION FAILED: is8Bit() at StringImpl::characters8() : [Attachment 236775] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 133574: ASSERTION FAILED: is8Bit() at StringImpl::characters8()
https://bugs.webkit.org/show_bug.cgi?id=133574

Attachment 236775: Patch
https://bugs.webkit.org/attachment.cgi?id=236775&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236775&action=review


> Source/JavaScriptCore/runtime/JSString.h:204
> +	   mutable unsigned m_flags;

I think it’s a little peculiar to make this change, but I think what makes it
clear that it’s right is that this is closely associated with m_value and the
two need to match. Too bad m_length is between this and m_value, making it
really hard to see that connection.