[webkit-reviews] review granted: [Bug 136025] Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator : [Attachment 236732] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 18 10:57:38 PDT 2014
Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 136025: Web Inspector: Rename DOM.RGBA and remove workarounds in the
bindings generator
https://bugs.webkit.org/show_bug.cgi?id=136025
Attachment 236732: Patch
https://bugs.webkit.org/attachment.cgi?id=236732&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236732&action=review
r=me
>
Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-
type.json-result:363
> namespace Test {
> -class HappyName;
> class ParameterBundle;
> +class UnpleasantName;
> } // Test
You could get rid of the UnpleasantName portion of this test if you wanted.
Fine to leave it in though.
More information about the webkit-reviews
mailing list