[webkit-reviews] review granted: [Bug 136010] REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme : [Attachment 236761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 18 08:55:10 PDT 2014


Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 136010: REGRESSION (r167856): adobe.com no longer able to launch Create
Cloud app using a URL with a custom scheme
https://bugs.webkit.org/show_bug.cgi?id=136010

Attachment 236761: Patch
https://bugs.webkit.org/attachment.cgi?id=236761&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I’ll have to take your word for the fact that this is right and covers all the
cases. I can’t follow all the different paths from reading the code. I suppose
test coverage also may make it sufficiently clear. But the logic here is quite
hard to follow. I am hoping that later we can disallow invalid URLs in even
more cases, while allowing them in the few cases that we need to; I hope that
eventually the default behavior can be No instead of Yes. It also seems like a
serious problem that the frame loader has so many different load calls.


More information about the webkit-reviews mailing list