[webkit-reviews] review granted: [Bug 136029] [Mac] Gesture scrolls don't work in the WebKit1 clients after scrolling a non-scrollable iFrame : [Attachment 236736] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 136029: [Mac] Gesture scrolls don't work in the WebKit1 clients after
scrolling a non-scrollable iFrame
https://bugs.webkit.org/show_bug.cgi?id=136029

Attachment 236736: Patch
https://bugs.webkit.org/attachment.cgi?id=236736&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236736&action=review


> Source/WebCore/page/mac/EventHandlerMac.mm:923
> +    // If the platform widget is a frame view (IFrame), and we are in
WebKit1, 'passWheelEventToWidget' has already
> +    // called 'scrollWheel' on the underlying platform widget. We need to
return true in this case to avoid getting
> +    // multiple copies of the scrollWheel event sent to the platform widget.


IS such a long comment really necessary? I'd suggest no comment, or a one-liner
stating the reason.