[webkit-reviews] review granted: [Bug 136010] REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme : [Attachment 236707] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 16 13:32:06 PDT 2014


Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 136010: REGRESSION (r167856): adobe.com no longer able to launch Create
Cloud app using a URL with a custom scheme
https://bugs.webkit.org/show_bug.cgi?id=136010

Attachment 236707: Patch
https://bugs.webkit.org/attachment.cgi?id=236707&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236707&action=review


> Source/WebCore/loader/FrameLoader.cpp:2901
> +    bool willRedirectToInvalidURL = m_quickRedirectComing &&
!request.url().isValid();

What about non-redirect requests that are for an invalid URL? The code in
NavigationScheduler applies for scheduleLocationChange, not just
scheduleRedirect.


More information about the webkit-reviews mailing list