[webkit-reviews] review granted: [Bug 135988] Native library inlining crashes when module isn't found : [Attachment 236663] fixed native library inlining in the ftl segfaulting

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Matthew Mirman
<mmirman at apple.com>'s request for review:
Bug 135988: Native library inlining crashes when module isn't found
https://bugs.webkit.org/show_bug.cgi?id=135988

Attachment 236663: fixed native library inlining in the ftl segfaulting
https://bugs.webkit.org/attachment.cgi?id=236663&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236663&action=review


> Source/JavaScriptCore/ChangeLog:15
> +	   (JSC::FTL::LowerDFGToLLVM::compilePutById): 
> +	   abstracted out Options::verboseCompilation as was the case in the
rest of the file.
> +	   (JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
> +	   (JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): 
> +	   added output error messages for llvm module loading.

Best to capitalize these sentences.