[webkit-reviews] review granted: [Bug 135974] master.cfg should handle special return codes of run-perf-tests : [Attachment 236647] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 15 11:23:44 PDT 2014


Ryosuke Niwa <rniwa at webkit.org> has granted Nagy Renátó
<nagy.renato at stud.u-szeged.hu>'s request for review:
Bug 135974: master.cfg should handle special return codes of run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=135974

Attachment 236647: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=236647&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236647&action=review


> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:729
> +	       if cmd.rc == 255:

Can we use -1 & 0xff instead to match the code in perftestrunner.py?


More information about the webkit-reviews mailing list