[webkit-reviews] review granted: [Bug 135968] CSS JIT: compile :-webkit-full-page-media : [Attachment 236644] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 135968: CSS JIT: compile :-webkit-full-page-media
https://bugs.webkit.org/show_bug.cgi?id=135968

Attachment 236644: Patch
https://bugs.webkit.org/attachment.cgi?id=236644&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236644&action=review


> Source/WebCore/ChangeLog:10
> +	   It would be possible to inline it, but this selector is so unommon I
don't think

Typo: should be "uncommon".

> Source/WebCore/css/SelectorCheckerTestFunctions.h:76
> +ALWAYS_INLINE bool isMediaDocument(const Element* element)

Does this have to take a const? Node/Element constness is a highly questionable
concept, which I thought we agreed to not use, see
<https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>.