[webkit-reviews] review granted: [Bug 135968] CSS JIT: compile :-webkit-full-page-media : [Attachment 236644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 15 10:07:45 PDT 2014

Alexey Proskuryakov <ap at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 135968: CSS JIT: compile :-webkit-full-page-media

Attachment 236644: Patch

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236644&action=review

> Source/WebCore/ChangeLog:10
> +	   It would be possible to inline it, but this selector is so unommon I
don't think

Typo: should be "uncommon".

> Source/WebCore/css/SelectorCheckerTestFunctions.h:76
> +ALWAYS_INLINE bool isMediaDocument(const Element* element)

Does this have to take a const? Node/Element constness is a highly questionable
concept, which I thought we agreed to not use, see

More information about the webkit-reviews mailing list