[webkit-reviews] review granted: [Bug 135958] CSS JIT: compile the :empty pseudo class : [Attachment 236629] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 14 21:00:32 PDT 2014

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 135958: CSS JIT: compile the :empty pseudo class

Attachment 236629: Patch

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236629&action=review


> Source/WebCore/cssjit/SelectorCompiler.cpp:2465
> +static void jumpIfElementIsNotEmpty(Assembler& assembler, RegisterAllocator
&registerAllocator, Assembler::JumpList& notEmptyCases, Assembler::RegisterID

RegisterAllocator& (& placement)

> Source/WebCore/cssjit/SelectorCompiler.cpp:2515
> +    if (m_selectorContext == SelectorContext::QuerySelector) {
> +	   jumpIfElementIsNotEmpty(m_assembler, m_registerAllocator,
failureCases, elementAddressRegister);
> +	   return;
> +    }

The querySelector path is so nice and tidy.
Is the affected-by-empty bit optimization really necessary?

More information about the webkit-reviews mailing list