[webkit-reviews] review granted: [Bug 135948] [Win] Extend auto-version.pl and version-stamp.pl to account for RC_ProjectBuildVersion : [Attachment 236609] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 135948: [Win] Extend auto-version.pl and version-stamp.pl to account for
RC_ProjectBuildVersion
https://bugs.webkit.org/show_bug.cgi?id=135948

Attachment 236609: Patch
https://bugs.webkit.org/attachment.cgi?id=236609&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236609&action=review


r=me, but please add tests for the override behavior.

> WebKitLibraries/win/tools/scripts/auto-version.pl:152
> +    my $RETURN_NANO_VERSION = $ENV{RC_ProjectBuildVersion} ||
$ENV{RC_PROJECTBUILDVERSION} || $BUILD_MICRO_VERSION;

Nit:  Should be consistent here and use '' quotes around the hash key like the
code above.