[webkit-reviews] review granted: [Bug 135890] IndexedDB should respect SchemeRegistry's database access setting : [Attachment 236604] added test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 14 12:43:59 PDT 2014

Alexey Proskuryakov <ap at webkit.org> has granted Martin Hock <mhock at apple.com>'s
request for review:
Bug 135890: IndexedDB should respect SchemeRegistry's database access setting

Attachment 236604: added test

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236604&action=review

> LayoutTests/storage/indexeddb/private-browsing-affects-indexeddb.html:7
> +if (window.testRunner) {
> +    testRunner.dumpAsText();
> +}

You could have used js-test harness to get this and logging for free.

> LayoutTests/storage/indexeddb/private-browsing-affects-indexeddb.html:23
> +    if (!indexedDB.open('test1')) {
> +	   log("Could not open test IndexedDB, exiting test.");
> +	   return;
> +    }

I'm not sure if this is useful. We have all the other tests to verify that
IndexedDB works, and dynamic changes to private browsing mode are not really

More information about the webkit-reviews mailing list