[webkit-reviews] review granted: [Bug 135941] [Services with UI] Selection services don't work inside <iframes> : [Attachment 236595] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 135941: [Services with UI] Selection services don't work inside <iframes>
https://bugs.webkit.org/show_bug.cgi?id=135941

Attachment 236595: Patch
https://bugs.webkit.org/attachment.cgi?id=236595&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236595&action=review


> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:524
> +    FrameView* viewForRange = selectionRange ?
selectionRange->ownerDocument().view() : nullptr;

You dereference this inside the loop; should we just bail if !selectionRange
instead?