[webkit-reviews] review denied: [Bug 135919] Add LayoutUnit argument coders to WebCoreArgumentCoders : [Attachment 236576] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 135919: Add LayoutUnit argument coders to WebCoreArgumentCoders
https://bugs.webkit.org/show_bug.cgi?id=135919

Attachment 236576: Patch
https://bugs.webkit.org/attachment.cgi?id=236576&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236576&action=review


r- for using int.

> Source/WebKit2/ChangeLog:3
> +	   Add LayoutUnit argument coders to WebCoreArgumentCoders

It seems a little bit strange to expose internals of layout machinery even to
WebKit, and more so to UI process. Can we use whatever type is exposed in API
until we get down to WebCore?

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:343
> +    int decodedRawValue;

IPC always uses fixed size types, like uint64_t, not int.