[webkit-reviews] review denied: [Bug 135874] The setter of binaryType attribute in WebSocket should raise the exception. : [Attachment 236578] Modify typos on a test html file.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jinwoo Jeong
<jw00.jeong at samsung.com>'s request for review:
Bug 135874: The setter of binaryType attribute in WebSocket should raise the
exception.
https://bugs.webkit.org/show_bug.cgi?id=135874

Attachment 236578: Modify typos on a test html file.
https://bugs.webkit.org/attachment.cgi?id=236578&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236578&action=review


Code change is OK, test change is not. See comments below.

> LayoutTests/http/tests/websocket/tests/hybi/binary-type.html:12
> +var syntaxErr = "SyntaxError";

This is not needed.

> LayoutTests/http/tests/websocket/tests/hybi/binary-type.html:-21
> -debug("Set invalid values to binaryType. They should be ignored. No
exception should be thrown.");

I don’t think this is needed at all. We should just delete it and not add new
debug lines.

> LayoutTests/http/tests/websocket/tests/hybi/binary-type.html:-24
> -ws.binaryType = "Blob";
> -shouldBeEqualToString("ws.binaryType", "blob");

The change needed here is much smaller than what's done below. It should just
be this.

    shouldThrow("ws.binaryType = 'Blob'", "SyntaxError");
    shouldBeEqualToString("ws.binaryType", "blob");

But also, binary-type-expected.txt has to be updated too since the expected
results are changing.