[webkit-reviews] review granted: [Bug 135918] [Services with UI] Use a longer delay duration for editable content : [Attachment 236568] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 135918: [Services with UI] Use a longer delay duration for editable content
https://bugs.webkit.org/show_bug.cgi?id=135918

Attachment 236568: Patch
https://bugs.webkit.org/attachment.cgi?id=236568&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236568&action=review


> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:408
> +    std::chrono::steady_clock::duration
minimumTimeUntilHighlightShouldBeShown =
m_webPage.corePage()->focusController().focusedOrMainFrame().selection().select
ion().isContentEditable() ? 1000_ms : 200_ms;

This line is crazy long; could we maybe pull the 'isContentEditable' check out
onto its own line? Also, could we maybe move the two constants to the top of
the file?