[webkit-reviews] review granted: [Bug 135916] Web Inspector: eslint configuration should be stored as .eslintrc : [Attachment 236565] [PATCH] adding .eslintrc

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Jono Wells
<jonowells at apple.com>'s request for review:
Bug 135916: Web Inspector: eslint configuration should be stored as .eslintrc
https://bugs.webkit.org/show_bug.cgi?id=135916

Attachment 236565: [PATCH] adding .eslintrc
https://bugs.webkit.org/attachment.cgi?id=236565&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236565&action=review


I think this is a reasonable starting point. This will be fun to extend!

> Source/WebInspectorUI/.eslintrc:38
> +    "globals": {
> +	   "ConsoleAgent": true,
> +	   "DOMAgent": true,
> +	   "InspectorBackend": true,
> +	   "InspectorFrontendHost": true,
> +	   "PageAgent": true,
> +	   "WebInspector": true
> +    },

All of the agents will need to be defined in here:

    shell> cd Source
    shell> find . | egrep 'protocol\/.*?json$' | xargs basename | sed -e
's/\.json/Agent/'
    ConsoleAgent
    DebuggerAgent
    GenericTypesAgent # Note we this is a supplemental file so you don't want
it.
    InspectorDomainAgent # Note this would just be "InspectorAgent".
    ProfilerAgent
    RuntimeAgent
    ApplicationCacheAgent
    CSSAgent
    DatabaseAgent
    DOMAgent
    DOMDebuggerAgent
    DOMStorageAgent
    IndexedDBAgent
    LayerTreeAgent
    NetworkAgent
    PageAgent
    ReplayAgent
    TimelineAgent
    WorkerAgent

And we will want:

    CodeMirror

> Source/WebInspectorUI/.eslintrc:40
> +	   "eqeqeq": 0,

Whoa whoa. We certainly want this on! Maybe not inside UserInterface/External
for CodeMirror / Esprima.