[webkit-reviews] review granted: [Bug 135551] [iOS] run-webkit-tests chokes on unterminated UTF-8 when writing a test result : [Attachment 236053] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Farler <dfarler at apple.com>'s
request for review:
Bug 135551: [iOS] run-webkit-tests chokes on unterminated UTF-8 when writing a
test result
https://bugs.webkit.org/show_bug.cgi?id=135551

Attachment 236053: Patch
https://bugs.webkit.org/attachment.cgi?id=236053&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236053&action=review


> Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:178
> +    sleep(2);

I suggest we add a comment here that explain why we need to wait 2 seconds as
it isn't obvious given that we already waited for the device to boot above.

> Tools/Scripts/webkitpy/port/ios.py:369
> +	   except ScriptError:
> +	       return '/Applications/Xcode.app/Contents/Developer'

How did you come to the decision to hard code the path
"/Applications/Xcode.app/Contents/Developer" when xcode-select errors out as
opposed to having the script fail with an error about the Xcode installation on
the machine? In particular, what circumstances do you envision xcode-select
failing and it being reasonable to assume that Xcode is installed?