[webkit-reviews] review denied: [Bug 135900] Do not use FloatRect::infiniteRect() to flag full repaints. : [Attachment 236546] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 135900: Do not use FloatRect::infiniteRect() to flag full repaints.
https://bugs.webkit.org/show_bug.cgi?id=135900

Attachment 236546: Patch
https://bugs.webkit.org/attachment.cgi?id=236546&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236546&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:716
> +    m_needsFullRepaint = true;
> +    m_dirtyRects.clear();
> +    noteLayerPropertyChanged(DirtyRectsChanged);
> +    addRepaintRect(FloatRect(FloatPoint(), m_size));

This is missing the if (!drawsContent()) that setNeedsDisplayInRect() does.