[webkit-reviews] review granted: [Bug 135640] [EFL] Add API to set application name for the user agent : [Attachment 236505] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 13 02:54:24 PDT 2014


Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 135640: [EFL] Add API to set application name for the user agent
https://bugs.webkit.org/show_bug.cgi?id=135640

Attachment 236505: Patch
https://bugs.webkit.org/attachment.cgi?id=236505&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236505&action=review


LGTM too.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:715
> + * @note If you just want to add your application name in ther user agent,

typo : ther -> the or their ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:741
> + * where the origin server selects suitable content or operating parameters
for the response (wikipedia).

IMHO, "(wikipedia)" looks redundant comment.


More information about the webkit-reviews mailing list