[webkit-reviews] review granted: [Bug 135756] Elements whose contents start with an astral Unicode symbol disappear when CSS `::first-letter` is applied to them : [Attachment 236483] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135756: Elements whose contents start with an astral Unicode symbol
disappear when CSS `::first-letter` is applied to them
https://bugs.webkit.org/show_bug.cgi?id=135756

Attachment 236483: Patch
https://bugs.webkit.org/attachment.cgi?id=236483&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236483&action=review


> Source/WebCore/html/HTMLTextAreaElement.cpp:324
> +    return
proposedValue.left(numCharactersInGraphemeClusters(StringView(proposedValue),
maxLength));

Is the explicit conversion to StringView needed? I’d expect an implicit
conversion.

> Source/WebCore/html/TextFieldInputType.cpp:341
> +    unsigned newLength = numCharactersInGraphemeClusters(StringView(string),
maxLength);

Is the explicit conversion to StringView needed? I’d expect an implicit
conversion.

> Source/WebCore/platform/LocalizedStrings.cpp:85
> +    unsigned numberOfCharacters =
numCharactersInGraphemeClusters(StringView(trimmed),
maxNumberOfGraphemeClustersInLookupMenuItem);

Is the explicit conversion to StringView needed? I’d expect an implicit
conversion.