[webkit-reviews] review granted: [Bug 135838] ASSERTION FAILED: m_intervalBegin.isFinite() in WebCore::SVGSMILElement::notifyDependentsIntervalChanged : [Attachment 236442] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Renata Hodovan
<rhodovan.u-szeged at partner.samsung.com>'s request for review:
Bug 135838: ASSERTION FAILED: m_intervalBegin.isFinite() in
WebCore::SVGSMILElement::notifyDependentsIntervalChanged
https://bugs.webkit.org/show_bug.cgi?id=135838

Attachment 236442: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=236442&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236442&action=review


> Source/WebCore/svg/animation/SVGSMILElement.cpp:308
> +    if (!ok || !SMILTime(result).isFinite())

Seems fine, but don’t we also want to reject negative numbers? Also, I see the
code to construct an SMILTime rejects NaN. What prevents toDouble from
returning NaN?