[webkit-reviews] review granted: [Bug 135848] [iOS] Make WTF, JavaScriptCore, and bmalloc build with the public SDK : [Attachment 236459] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 135848: [iOS] Make WTF, JavaScriptCore, and bmalloc build with the public
SDK
https://bugs.webkit.org/show_bug.cgi?id=135848

Attachment 236459: Patch
https://bugs.webkit.org/attachment.cgi?id=236459&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236459&action=review


r=me

> Source/bmalloc/bmalloc/PerThread.h:39
> +#elif BPLATFORM(IOS_SIMULATOR)
> +const pthread_key_t __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 = 90;
> +INLINE int _pthread_setspecific_direct(pthread_key_t key, const void* value)
{ return pthread_setspecific(key, value); }
> +INLINE void* _pthread_getspecific_direct(pthread_key_t key) { return
pthread_getspecific(key); }
> +extern "C" int pthread_key_init_np(int, void (*destructor)(void*));

Does the __thread code patch not work in the iOS simulator? If it does work, I
think it would be slightly better, so we wouldn't have the brittleness of
defining this constant for ourselves.