[webkit-reviews] review granted: [Bug 135844] Don't recurse into non-rendered subtrees when computing style : [Attachment 236463] patch 2

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 135844: Don't recurse into non-rendered subtrees when computing style
https://bugs.webkit.org/show_bug.cgi?id=135844

Attachment 236463: patch 2
https://bugs.webkit.org/attachment.cgi?id=236463&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236463&action=review


r=me

> Source/WebCore/ChangeLog:11
> +	   Do a simple reset of the style dirty bits and any computed style in
non-renderer subtrees.

Typo, non-renderer -> non-rendered.

> Source/WebCore/style/StyleResolveTree.cpp:561
> +    for (auto& child : childrenOfType<Element>(current)) {

I suspect this could be more efficient with elementDescendants.