[webkit-reviews] review granted: [Bug 135839] Media document sends incorrect referer header : [Attachment 236445] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 08:28:38 PDT 2014


Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 135839: Media document sends incorrect referer header
https://bugs.webkit.org/show_bug.cgi?id=135839

Attachment 236445: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=236445&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236445&action=review


> Source/WebCore/html/MediaDocument.cpp:148
> +    if (frame)
> +	   m_referrer = frame->loader().outgoingReferrer();

The Document class doesn't stash it's referrer; it fetches it from the loader
each time it's requested.  I'm concerned that there may be some situation where
we don't have a frame at creation time, but get one later.

(Though maybe it's something which Document has to worry about but not
MediaDocument.)

Also, if we do decide to stash the outgoing referrer, we should probably name
the variable m_outgoingReferrer.

Other than that nit, r=me.


More information about the webkit-reviews mailing list