[webkit-reviews] review granted: [Bug 135727] Cached file backed resources don't make it to the Web Process when NETWORK_CFDATA_ARRAY_CALLBACK is enabled : [Attachment 236390] Patch2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Pratik Solanki <psolanki at apple.com>'s
request for review:
Bug 135727: Cached file backed resources don't make it to the Web Process when
NETWORK_CFDATA_ARRAY_CALLBACK is enabled
https://bugs.webkit.org/show_bug.cgi?id=135727

Attachment 236390: Patch2
https://bugs.webkit.org/attachment.cgi?id=236390&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236390&action=review


> Source/WebCore/ChangeLog:10
> +	   Add SharedBuffer::copyCFDataNoCreate() which returns CFDataRef if it
has one. Refactor
> +	   this code out of createCFData().

I don’t like the grammar of the phrase “copy CFData no create”. I’d prefer
copyExistingCFData or copyCFDataWithoutCreating.

> Source/WebCore/platform/mac/SharedBufferMac.mm:148
> +    RetainPtr<CFDataRef> cfData = copyCFDataNoCreate();
> +    if (cfData)
> +	   return cfData;

Would be nice to put the definition inside the if statement.