[webkit-reviews] review granted: [Bug 135791] [EFL][WK2] Minibrowser: Enhance the application to use download directory selector : [Attachment 236351] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 11 21:07:30 PDT 2014


Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 135791: [EFL][WK2] Minibrowser: Enhance the application to use download
directory selector
https://bugs.webkit.org/show_bug.cgi?id=135791

Attachment 236351: Patch
https://bugs.webkit.org/attachment.cgi?id=236351&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236351&action=review


Looks fine.

> Tools/MiniBrowser/efl/main.c:662
> +    Eina_Stringshare *save_file_path = show_file_entry_dialog(window,
"DOWNLOAD", home_path ? home_path : "/home");

Isn't it better to use /tmp when *home_path* isn't set ?

> Tools/MiniBrowser/efl/main.c:674
> +	   eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX");

Can't we change download file name as well ?


More information about the webkit-reviews mailing list