[webkit-reviews] review granted: [Bug 135814] [Mac, iOS] Some media content never reaches full 'loaded' state : [Attachment 236419] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 135814: [Mac, iOS] Some media content never reaches full 'loaded' state
https://bugs.webkit.org/show_bug.cgi?id=135814

Attachment 236419: Patch
https://bugs.webkit.org/attachment.cgi?id=236419&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236419&action=review


Looks good! r=me.  It's good to see all those narrowPrecisionToFloat() calls
gone.

> LayoutTests/platform/mac/media/video-seek-past-end-paused-expected.txt:15
> -EXPECTED (mediaElement.currentTime == 'mediaElement.duration'), OBSERVED
'6.026666641235352' FAIL
> +EXPECTED (mediaElement.currentTime == 'mediaElement.duration'), OBSERVED
'6.026666666666666' FAIL

Ahh, this is how you know it's working. ;)