[webkit-reviews] review granted: [Bug 135820] More adjustments to css width calculations of cue boxes : [Attachment 236413] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 11 16:59:38 PDT 2014

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 135820: More adjustments to css width calculations of cue boxes

Attachment 236413: patch

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236413&action=review

r=me, but please address the possible zero-base-font-size issue I mentioned.

> Source/WebCore/html/track/TextTrackCueGeneric.cpp:82
> +	   double authorFontSize = videoSize.height() *
cue->baseFontSizeRelativeToVideoHeight() / 100.0;

Can baseFontSizeRelativeToVideoHeight ever be zero (I think it can be)? If the
author could arbitrarily set this to zero, I think we should check and fall
back to that minimum (10 pt) value from the CSS.

More information about the webkit-reviews mailing list