[webkit-reviews] review requested: [Bug 135423] Allow high fidelity type profiling to be enabled and disabled. : [Attachment 236403] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 11 14:31:10 PDT 2014
Saam Barati <sbarati at apple.com> has asked for review:
Bug 135423: Allow high fidelity type profiling to be enabled and disabled.
https://bugs.webkit.org/show_bug.cgi?id=135423
Attachment 236403: patch
https://bugs.webkit.org/attachment.cgi?id=236403&action=review
------- Additional Comments from Saam Barati <sbarati at apple.com>
- Merged op_put_to_scope_with_profile and op_get_from_scope_with_profile into
op_profile_types_with_high_fidelity by adding extra arguments to the opcode.
- Altered SymbolTable to use less memory by adding a rare data structure for
type profiling.
- Created an interface to turn on and off type profiling from the Web
Inspector.
- Refactored how entries are written to HighFidelityLog to make it
easier to inline when generating machine code.
- Implemented op_profile_types_with_high_fidelity in the baseline JIT
by inlining the process of writing to the log and doing a small amount
of type inference optimizations.
More information about the webkit-reviews
mailing list