[webkit-reviews] review granted: [Bug 135170] Web Inspector: show a replay dashboard when capturing or replaying : [Attachment 236043] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135170: Web Inspector: show a replay dashboard when capturing or replaying
https://bugs.webkit.org/show_bug.cgi?id=135170

Attachment 236043: Patch
https://bugs.webkit.org/attachment.cgi?id=236043&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236043&action=review


> Source/WebInspectorUI/ChangeLog:20
> +	   * UserInterface/Images/ReplayPauseButton.svg: Added.
> +	   * UserInterface/Images/ReplayPlayButton.svg: Added.
> +	   * UserInterface/Images/ReplayRecordingButton.svg: Added.

Once this lands I will take a look at making new icons for these to match
10.10.

> Source/WebInspectorUI/UserInterface/Views/ReplayDashboardView.js:62
> +    if (WebInspector.replayManager.sessionState ===
WebInspector.ReplayManager.SessionState.Capturing)
> +	   this._captureStarted();
> +    else if (WebInspector.replayManager.sessionState ===
WebInspector.ReplayManager.SessionState.Inactive)
> +	   this._captureStopped();
> +    // ReplayManager.sessionState must be Replaying.
> +    else if (WebInspector.replayManager.segmentState ===
WebInspector.ReplayManager.SegmentState.Dispatching)
> +	   this._playbackStarted();
> +    // ReplayManager.sessionState must be Unloaded or Loaded, so execution
is paused.
> +    else
> +	   this._playbackPaused();

switch?