[webkit-reviews] review granted: [Bug 135690] Web Inspector: DebuggerManager commands should return promises : [Attachment 236318] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 135690: Web Inspector: DebuggerManager commands should return promises
https://bugs.webkit.org/show_bug.cgi?id=135690

Attachment 236318: Patch
https://bugs.webkit.org/attachment.cgi?id=236318&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236318&action=review


> Source/WebInspectorUI/UserInterface/Base/EventListenerSet.js:27
> +WebInspector.EventListener = function(thisObject, fireOnce)

Should be a seperate file.

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:158
> +		   throw error;

Why throw?