[webkit-reviews] review granted: [Bug 135476] Implement long mouse press over links. Part of 135257 - Add long mouse press gesture. : [Attachment 236311] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Peyton Randolph
<prandolph at apple.com>'s request for review:
Bug 135476: Implement long mouse press over links. Part of 135257 - Add long
mouse press gesture.
https://bugs.webkit.org/show_bug.cgi?id=135476

Attachment 236311: Patch
https://bugs.webkit.org/attachment.cgi?id=236311&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236311&action=review


> Source/WebCore/page/EventHandler.cpp:136
> +const std::chrono::milliseconds LongMousePressRecognitionDelay = 500_ms;
> +const int MaximumLongMousePressDragDistance = 5; // in points.

Lowercase leading letters was actually correct, the things around here are
wrong :D

> Source/WebCore/page/EventHandler.h:384
> +    bool mouseMovementExceedsThreshold(const FloatPoint&, const int
pointsThreshold) const;

Sounds good to me!

Don't think you need the 'const' on the int parameter (some would even say
const reference is overkill for FloatPoint, but I will leave that be).