[webkit-reviews] review denied: [Bug 135766] [WinCairo] Enable GStreamer. : [Attachment 236306] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 8 15:48:53 PDT 2014

Alex Christensen <achristensen at apple.com> has denied peavo at outlook.com's
request for review:
Bug 135766: [WinCairo] Enable GStreamer.

Attachment 236306: Patch

------- Additional Comments from Alex Christensen <achristensen at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236306&action=review

I would r+ most of this, except Platform.h.  I left the GStreamer property
sheets in to not remove the future possibility of using GStreamer.

> Source/WTF/wtf/Platform.h:861
> +#define WTF_USE_GLIB 1

I think people want glib to not be a dependency.  See the discussion after
I'm ok with putting the rest of these changes in to make your work easier, but
I do not want to switch the default build to GStreamer unless it works with
seeking and loading correctly.	
https://bugs.webkit.org/show_bug.cgi?id=127376 (which I'm not working on any

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:134
> +    <Import
Project="..\..\..\WebKitLibraries\win\tools\vsprops\GStreamer32.props" />

Let's import GStreamerCommon.props here, too.  It's not needed, but we might
want to do global changes later without wondering why WebCore is not changing.

More information about the webkit-reviews mailing list